search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/a11y improvements #2004

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This addresses nearly all of the a11y issues around datatables from https://github.com/18F/openFEC-web-app/issues/1935 .

Chrome Auditor is still showing an error for Elements with ARIA roles must ensure required owned elements are present, which as best I can tell was from the <tr role="row"> elements not being contained within an element with role="rowgroup". I added this and according to this it seems like it should pass, so I'm not sure why it's not.

codecov-io commented 7 years ago

Codecov Report

Merging #2004 into develop will decrease coverage by 0.02%. The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2004      +/-   ##
===========================================
- Coverage    55.74%   55.72%   -0.03%     
===========================================
  Files           48       48              
  Lines         3231     3234       +3     
  Branches       374      375       +1     
===========================================
+ Hits          1801     1802       +1     
- Misses        1420     1422       +2     
  Partials        10       10
Impacted Files Coverage Δ
static/js/modules/column-helpers.js 24% <ø> (+0.31%) :arrow_up:
static/js/modules/toggle.js 16.66% <0%> (ø) :arrow_up:
static/js/modules/tables.js 53.53% <25%> (-0.3%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98eb24d...a026508. Read the comment docs.