fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

adding loading image during results fetch #2021

Closed anthonygarvan closed 7 years ago

anthonygarvan commented 7 years ago

Thanks for the headstart @noahmanger , this was quick.

codecov-io commented 7 years ago

Codecov Report

Merging #2021 into develop will decrease coverage by 0.02%. The diff coverage is 38.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2021      +/-   ##
===========================================
- Coverage    55.35%   55.33%   -0.03%     
===========================================
  Files           48       48              
  Lines         3268     3273       +5     
  Branches       383      384       +1     
===========================================
+ Hits          1809     1811       +2     
- Misses        1443     1446       +3     
  Partials        16       16
Impacted Files Coverage Δ
static/js/legal/SearchResults.js 32.14% <30.76%> (+1.37%) :arrow_up:
static/js/legal/LegalSearch.js 83.92% <60%> (-2.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7127a8c...e294673. Read the comment docs.

noahmanger commented 7 years ago

Nice work!