search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Election year filter #2028

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

In https://github.com/18F/openFEC-web-app/pull/2000/commits/2d98e0e5220ed64024244159488fc99eb203e360 I changed the cycle filter on the House candidates data page to be a multi-select dropdown. But that was a mistake; it should only be a single-select dropdown, because we only want to look at one period of data at a time. Allowing multiple leads to duplicate results.

image

codecov-io commented 7 years ago

Codecov Report

Merging #2028 into release/public-beta-20170512 will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           release/public-beta-20170512    #2028   +/-   ##
=============================================================
  Coverage                         55.29%   55.29%           
=============================================================
  Files                                48       48           
  Lines                              3279     3279           
  Branches                            384      384           
=============================================================
  Hits                               1813     1813           
  Misses                             1450     1450           
  Partials                             16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13bfed1...c035943. Read the comment docs.