search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

minify assets #2037

Closed LindsayYoung closed 6 years ago

noahmanger commented 7 years ago

All the code is in place for this to work correctly, but it seems that the prod environment is not being picked up here.

@xtine can you look into this?

noahmanger commented 7 years ago

Does this variable need to be set for Travis specifically?

ccostino commented 7 years ago

Oh good question - it is being set here in the production manifest, but it's not set anywhere in .travis.yml. I imagine it has to be set either in the env section toward the top or exported explicitly in the before_deploy section (like the PATH environment variable is) in order for Travis to know to minify things before deploying.

noahmanger commented 7 years ago

Cool. Could you add this so we can take advantage with the next hotfix deploy?

ccostino commented 7 years ago

Added to your hotfix for the coverage dates, @noahmanger!

One thing though, this will affect all deploys through Travis, so the assets may also be minified in dev.

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1558 via ZenHub