fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code

Other

43 stars 31 forks source link

Feature/bulk data message #2083

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This addresses a couple interrelated issues that have surfaced over time:

Users have expressed difficulty figuring out how to control the dates and enter contributor names
The link in to the bulk data from the disabled export button tooltip is actually unclickable and not obvious

This implements the message pattern as designed in https://github.com/18F/openFEC-web-app/issues/2074 and also pulls out the contributor name and date filters to the top, open panel:

It makes a similar change to disbursements:

The pattern we're going for is to always expose filters for the two parties of any given transaction in the top, open panel (we already do this with independent expenditures) as well as any constraining factors, like time period.

Other details:

The message links to https://www.fec.gov/data/advanced/?tab=other for bulk downloads
The "Committee name or ID" field was relabelled to "Recipient name or ID" on receipts and individual contributions
The "Committee name or ID" field was relabelled to "Spender name or ID" on disbursements (same as it is on independent expenditures
The "Time period" filter was relabelled to "Transaction time period" to make clearer that it's referring to the time period the transaction was made within

cc @nickykrause

noahmanger commented 7 years ago

Thanks @jenniferthibault for pairing with me to figure this out in code, and @nickykrause for the smart design ideas.

jenniferthibault commented 7 years ago

One small addition: we also relabelled the accordions from the patternTransaction information to Transaction details to re-emphasize the model that there are some basic filters at the top, but more detailed options in each category below.

@nickykrause still very open to your thoughts and reactions—just because it's in a PR doesn't mean it's decided, it was just much, much less tedious to move the components in code than rebuilding them in the design files.

noahmanger commented 7 years ago

And this is how it looks on candidate / committee pages:

nickykrause commented 7 years ago

@jenniferthibault @noahmanger all looks good to me, but I appreciate the tag! 👍

codecov-io commented 7 years ago

Codecov Report

Merging #2083 into develop will decrease coverage by 0.22%. The diff coverage is 81.81%.

@@             Coverage Diff             @@
##           develop    #2083      +/-   ##
===========================================
- Coverage    55.29%   55.06%   -0.23%     
===========================================
  Files           48       48              
  Lines         3279     3265      -14     
  Branches       384      385       +1     
===========================================
- Hits          1813     1798      -15     
- Misses        1450     1451       +1     
  Partials        16       16

Impacted Files	Coverage Δ
static/js/modules/tables.js	`51.57% <81.81%> (-1.97%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e15b191...a27f922. Read the comment docs.