Change default election year to most recent only

[PaulClark2]

This seems to be causing some confusion. Let's change this to default to the most recent election year. I don't think that surprises folks.

: https://www.fec.gov/data/candidates/?election_year=2014&election_year=2016&election_year=2018&has_raised_funds=true

[jwchumley]

I think we should throw it over to Nicky. My thought is to remove the default year entirely since this is the advanced search. Without the defaults the current behavior would be that it would find everybody and when you click on one you automatically get the most recent activity year for that committee.

[rhoughfec]

I think this will be a common issue for enforcement attorneys and commission offices since a lot of their cases are 4-6 years behind the current election cycle. I agree Jeff, I think if we can remove the default entirely that would be great. Thanks guys!

[PaulClark2]

@nickykrause can you take a look at this?

[nickykrause]

Sure! I probably won't be able to 🤔 on it until later today, after usability testing/retro, but I am happy to look at it.

[noahmanger]

Easy enough fix. Removing the default probably does make sense in this case.

[rhoughfec]

Thanks @noahmanger !

[nickykrause]

@noahmanger - I just looked at it, and I agree. I wondered if there was a reason that we decided to have a default? Did it have anything to do with trying to add some limit to the number of results right up front? If so, is that something we actually need to be concerned about, or are we cool with removing the default and letting all the results appear (paginated, of course)?

[noahmanger]

IIRC (and this was very long ago) it was an attempt to just limit the universe to a more relevant set of results be default, but that feels less important now.

[noahmanger]

I assume we want to do the same for /committees?

[noahmanger]

Will be fixed in https://github.com/18F/openFEC-web-app/pull/2083

[nickykrause]

Makes sense to me