search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Sort documents in reverse chronological order #2091

Closed vrajmohan closed 7 years ago

vrajmohan commented 7 years ago

Fixes 18F/openFEC#2415

codecov-io commented 7 years ago

Codecov Report

Merging #2091 into develop will decrease coverage by 0.51%. The diff coverage is 30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2091      +/-   ##
===========================================
- Coverage    55.14%   54.62%   -0.52%     
===========================================
  Files           48       48              
  Lines         3275     3394     +119     
  Branches       387      420      +33     
===========================================
+ Hits          1806     1854      +48     
- Misses        1453     1524      +71     
  Partials        16       16
Impacted Files Coverage Δ
openfecwebapp/api_caller.py 57.06% <30%> (+0.26%) :arrow_up:
static/js/modules/columns.js 22.41% <0%> (+0.55%) :arrow_up:
static/js/modules/download.js 91.15% <0%> (+1.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2eff55...b042013. Read the comment docs.

anthonygarvan commented 7 years ago

Unfortunately I think this will need to be scrapped (sorry!). This story is to add sorting to the API, not the web app- the advisory opinion search no longer goes through the web app (the code you changed is deprecated and should have been removed- that's on me).

[edit: I was thinking about sorting legal results, not sorting documents within an ao for the canonical view. this is good to go, sorry for the alarm].