fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/raising spending candidate pages #2106

Closed xtine closed 7 years ago

xtine commented 7 years ago

Updates for raising/spending tabs on candidate pages. https://github.com/18F/openFEC-web-app/issues/2087

screen shot 2017-06-05 at 1 47 05 pm screen shot 2017-06-05 at 1 47 25 pm

Requires: https://github.com/18F/fec-style/pull/727

codecov-io commented 7 years ago

Codecov Report

Merging #2106 into develop will decrease coverage by 0.05%. The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2106      +/-   ##
===========================================
- Coverage    55.14%   55.08%   -0.06%     
===========================================
  Files           48       48              
  Lines         3275     3282       +7     
  Branches       387      387              
===========================================
+ Hits          1806     1808       +2     
- Misses        1453     1458       +5     
  Partials        16       16
Impacted Files Coverage Δ
openfecwebapp/views.py 41.53% <0%> (-0.65%) :arrow_down:
openfecwebapp/filters.py 64.38% <40%> (-1.8%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2eff55...6a3dfe9. Read the comment docs.

noahmanger commented 7 years ago

Handed off to me. I just:

noahmanger commented 7 years ago

@xtine your stuff looks good, so if you can review my commits then we can merge.