search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Removing disbursement purpose filter #2110

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This removes the disbursement purpose filter per the discussion in Slack. The logic behind this filter is still too complicated and inconsistent, and this functionality will soon be partially replaced by the line number filter.

image

cc @jwchumley

codecov-io commented 7 years ago

Codecov Report

Merging #2110 into develop will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2110      +/-   ##
===========================================
- Coverage    55.02%   55.01%   -0.02%     
===========================================
  Files           48       48              
  Lines         3291     3290       -1     
  Branches       388      388              
===========================================
- Hits          1811     1810       -1     
  Misses        1464     1464              
  Partials        16       16
Impacted Files Coverage Δ
openfecwebapp/constants.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f17c04...2d8b5bd. Read the comment docs.

LindsayYoung commented 7 years ago

Thanks!