fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/committee page cleanup #2113

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This contains a whole bunch of fixes to round out the work that began in https://github.com/18F/openFEC-web-app/pull/2106 to bring greater consistency to profile pages.

1. Page organization consistency

First, for groups that have additional forms of spending other than schedule B disbursements — i.e. groups that make IEs, electioneering comms, or communication costs — those tabs are now also organized under the new "Spending" tab:

image

image

image

2. Unified heading style

Second, it unifies the heading style used throughout these pages. Previously the titles and links to filter data varied depending on the table. Now, we use this pattern everywhere, using the title + button + border lockup we use elsewhere on the site: image image image image image

3. Misc. cleanup and fixes

Much thanks to @jenniferthibault on pairing through the nitty gritty details of this.

codecov-io commented 7 years ago

Codecov Report

Merging #2113 into develop will increase coverage by 0.59%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2113      +/-   ##
===========================================
+ Coverage    55.02%   55.62%   +0.59%     
===========================================
  Files           48       48              
  Lines         3291     3380      +89     
  Branches       388      392       +4     
===========================================
+ Hits          1811     1880      +69     
- Misses        1464     1484      +20     
  Partials        16       16
Impacted Files Coverage Δ
openfecwebapp/views.py 41.22% <0%> (-0.32%) :arrow_down:
static/js/modules/cycle-select.js 92.3% <100%> (ø) :arrow_up:
static/js/legal/LegalSearch.js 87.5% <0%> (+4.74%) :arrow_up:
openfecwebapp/api_caller.py 60.8% <0%> (+5.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42c2a49...1b44cc1. Read the comment docs.

xtine commented 7 years ago

This is great! Nice to unify the headers, and also always nice to remove code (tabs.html). 👍