fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/committee efilings #2118

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This is a blunt way of adding raw filings to committee pages: image

The way it works is:

Pro:

Cons:

cc @LindsayYoung @jwchumley

codecov-io commented 7 years ago

Codecov Report

Merging #2118 into release/public-20170614 will decrease coverage by 0.04%. The diff coverage is 37.5%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           release/public-20170614    #2118      +/-   ##
===========================================================
- Coverage                    54.99%   54.95%   -0.05%     
===========================================================
  Files                           48       48              
  Lines                         3291     3299       +8     
  Branches                       388      388              
===========================================================
+ Hits                          1810     1813       +3     
- Misses                        1465     1470       +5     
  Partials                        16       16
Impacted Files Coverage Δ
openfecwebapp/app.py 72.22% <ø> (ø) :arrow_up:
openfecwebapp/views.py 39.7% <0%> (-1.52%) :arrow_down:
openfecwebapp/utils.py 59.55% <100%> (+1.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f1c937...b5eac3a. Read the comment docs.

LindsayYoung commented 7 years ago

Looking now :)

LindsayYoung commented 7 years ago

This is a great addition thanks for getting to this so quickly