search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Show all transactions as first tab #2129

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This makes the "all transactions" tab the default opened tab. I meant to include this in https://github.com/18F/openFEC-web-app/pull/2127 but forgot to push before it was merged.

It also makes a change to account for the fact that our tab names are changing with this release. Now, if a something like ?tab=receipts is included in the URL (as would be the case if someone bookmarked that tab previously) the page will default to open the first tab, whatever that is. Previously it would instead show all tabs at once, which was wrong.

codecov-io commented 7 years ago

Codecov Report

Merging #2129 into release/public-20170614 will decrease coverage by 0.04%. The diff coverage is 0%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           release/public-20170614    #2129      +/-   ##
===========================================================
- Coverage                    54.53%   54.48%   -0.05%     
===========================================================
  Files                           49       49              
  Lines                         3341     3342       +1     
  Branches                       391      391              
===========================================================
- Hits                          1822     1821       -1     
- Misses                        1503     1505       +2     
  Partials                        16       16
Impacted Files Coverage Δ
static/js/vendor/tablist.js 67.39% <0%> (-3.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20baaf4...1aaff24. Read the comment docs.