search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Typeahead not suggesting known committees #2131

Closed PaulClark2 closed 7 years ago

PaulClark2 commented 7 years ago

Handel's Senate committee is not among the suggested committees in the typeahead.

image

If you submit the search, her Senate committee is amount the results. https://www.fec.gov/data/?search=handel

Is the typeahead seen as just a suggestion and a shortcut? If you don’t see what you are looking for among the suggestions, then you submit the search receiving a full set of results?

Are people taking the suggestions of the typeahead as definitive?

jenniferthibault commented 7 years ago

Expected committee to be returned is Handel for Senate, Inc

This looks like it was supposed to be resolved by https://github.com/18F/fec-style/pull/724 -- but the problem is still happening.

noahmanger commented 7 years ago

Looking into this today. Such a weird bug. I can see the results are returned by the API, and the typeahead is set to show the top 5 results for both candidates and committees.

Upping the limit from 5 to 10 shows the correct committees: image

But it also means that for more common terms (like "Ryan for") the list will be very long: image

jenniferthibault commented 7 years ago

Weird, so while it's SET to show the top 5 results for both, it's not. In Handel's case, it's only showing 1 committee.

Seems like there's a perception issue here too... users (press/public records office staff included) are perceiving this as a search that returns ALL matches, not only some of them. So there's some interface/copy design that could be needed.

noahmanger commented 7 years ago

Yeah I was thinking that too. There will always need to be some limit imposed, so might be good to tweak the microcopy. But regardless, if usually you see 5 matches but in some cases you see only 1, it's logical to think that the others don't exist.

jenniferthibault commented 7 years ago

@noahmanger is it worth keeping this issue open or filing a new one for the content/interaction design components?

noahmanger commented 7 years ago

Let's make a new one since this was focused on the bug.