search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Link aggregates to 4 or 6 year ranges #2133

Closed noahmanger closed 6 years ago

noahmanger commented 7 years ago

On the other spending tab of a candidate page, if you're looking at a 4 or 6 year range, the aggregates in the IE/EC/CC tables all still include the min and max dates for a 2 year range.

image

In order for the itemized data to accurately reflect the totals, we should make the min date equal to the start of the 4 or 6 year period.

The current behavior is because we have a single helper function that generates min and max dates for a two-year period: https://github.com/18F/openFEC-web-app/blob/master/static/js/modules/helpers.js#L154

h/t @PaulClark2 for catching this. cc @xtine .

noahmanger commented 7 years ago

Rolled this fix into https://github.com/18F/openFEC-web-app/pull/2213

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1540 via ZenHub