search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Pass candidate name in links to IE page #2138

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This goes with the fix to make raw/processed filters retain filter values https://github.com/18F/fec-style/pull/736.

This fix is because the candidate filter for processed IEs uses candidate ID but the candidate filter for raw IEs uses candidate name (because the ID hasn't been coded yet). So this passes the candidate name through so that when clicking through from this link and then toggling to raw it will show up:

image

codecov-io commented 7 years ago

Codecov Report

Merging #2138 into develop will decrease coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2138      +/-   ##
===========================================
- Coverage    53.84%   53.56%   -0.28%     
===========================================
  Files           52       52              
  Lines         3421     3476      +55     
  Branches       409      409              
===========================================
+ Hits          1842     1862      +20     
- Misses        1548     1583      +35     
  Partials        31       31
Impacted Files Coverage Δ
openfecwebapp/views.py 38.54% <0%> (-0.88%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 149c3bb...db15cff. Read the comment docs.