search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/report coverage dates & RFAI N/A version status #2139

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This adds coverage dates to the regularly filed reports table on committee pages: image

And the raw filings table: image

Resolves https://github.com/18F/FEC/issues/4217

It also rolls in an earlier requested change, which is to not show a version status on RFAIs, as they can't be amended: image

Resolves https://github.com/18F/FEC/issues/3942

It also fixes the negative page number issue by accounting for the fact that image numbers switched from 11 to 18 digits in 2015. This adds the code to just check the length and if it's 18 digits, it slices it after the first 8, and if it's not, it leaves it alone: image

Resolves https://github.com/18F/FEC/issues/4232 Resolves https://github.com/18F/openFEC/issues/2475

codecov-io commented 7 years ago

Codecov Report

Merging #2139 into develop will decrease coverage by 0.06%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2139      +/-   ##
===========================================
- Coverage    53.84%   53.78%   -0.07%     
===========================================
  Files           52       52              
  Lines         3421     3425       +4     
  Branches       409      411       +2     
===========================================
  Hits          1842     1842              
- Misses        1548     1552       +4     
  Partials        31       31
Impacted Files Coverage Δ
static/js/modules/columns.js 21.29% <0%> (-0.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 149c3bb...47577b6. Read the comment docs.