search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Hotfix/remove 24 48 #2140

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

While we're currently resolving bugs that are causing inconsistent results in the 24/48-hour reports data, this removes the filter for those and instead adds a warning and a link to the classic site: http://classic.fec.gov/data/IndependentExpenditure.do

image

Also, it fixes an unrelated bug where the total receipts/disbursements numbers on raising and spending pages were referencing the raising_summary and spending_summary dictionaries, but those dictionaries are only created if there's totals and reports. The template already checks for totals before showing this figure, so since there's no reason to not just use that number directly, this does that.

codecov-io commented 7 years ago

Codecov Report

Merging #2140 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2140   +/-   ##
=======================================
  Coverage   54.48%   54.48%           
=======================================
  Files          49       49           
  Lines        3342     3342           
  Branches      391      391           
=======================================
  Hits         1821     1821           
  Misses       1505     1505           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb180a5...c36f16d. Read the comment docs.