fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Hide net contributions and operating expenditures #2142

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This hides the net operating expenditures and net contributions numbers (and their child lines) as the underlying logic needs some work.

The cash summary portion of financial summaries now looks like: image

Worth nothing that these numbers are only incorrect for certain committees, but when they're wrong they're also wrong in the classic viewer.

codecov-io commented 7 years ago

Codecov Report

Merging #2142 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2142   +/-   ##
========================================
  Coverage    53.84%   53.84%           
========================================
  Files           52       52           
  Lines         3421     3421           
  Branches       409      409           
========================================
  Hits          1842     1842           
  Misses        1548     1548           
  Partials        31       31
Impacted Files Coverage Δ
openfecwebapp/constants.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcb2bb0...a73dfde. Read the comment docs.

LindsayYoung commented 7 years ago

Thanks! Checked this out locally and makes sense. I think the local test data on the API could use some more presidential.