Closed noahmanger closed 7 years ago
Merging #2143 into develop will decrease coverage by
0.73%
. The diff coverage is16.66%
.
@@ Coverage Diff @@
## develop #2143 +/- ##
===========================================
- Coverage 53.84% 53.11% -0.74%
===========================================
Files 52 52
Lines 3421 3694 +273
Branches 409 445 +36
===========================================
+ Hits 1842 1962 +120
- Misses 1548 1700 +152
- Partials 31 32 +1
Impacted Files | Coverage Δ | |
---|---|---|
openfecwebapp/constants.py | 100% <ø> (ø) |
:arrow_up: |
static/js/modules/columns.js | 20.38% <ø> (-1.47%) |
:arrow_down: |
openfecwebapp/routes.py | 46.54% <16.66%> (+1.75%) |
:arrow_up: |
openfecwebapp/views.py | 39.23% <0%> (-0.19%) |
:arrow_down: |
static/js/legal/LegalSearch.js | 83.33% <0%> (+0.23%) |
:arrow_up: |
static/js/legal/SearchResults.js | 34.28% <0%> (+2.14%) |
:arrow_up: |
openfecwebapp/api_caller.py | 64.25% <0%> (+8.57%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fcb2bb0...4a39dd7. Read the comment docs.
is there a companion pr that implements the search?
Thanks!
This is just an experiment to tackle a couple unrelated image number feature requests. The first is to add an image number column to the main filings table and the second is to add functionality to the main data search so that entering an image number pulls up a filing.
We still need to figure out if/how we want to do this, but it was an easy thing to test so filing a PR so I don't lose track of the work.
Resolves https://github.com/18F/openFEC-web-app/issues/2055 Resolves https://github.com/18F/openFEC-web-app/issues/2054