search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Added flag for ethnio screener script to open fec web app #2152

Closed patphongs closed 7 years ago

patphongs commented 7 years ago

Added Ethnio Screener to data pages. Resolves this issue: https://github.com/18F/openFEC-web-app/issues/2080

codecov-io commented 7 years ago

Codecov Report

Merging #2152 into develop will decrease coverage by 1.9%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2152      +/-   ##
===========================================
- Coverage    56.12%   54.22%   -1.91%     
===========================================
  Files           50       52       +2     
  Lines         3207     3727     +520     
  Branches       387      467      +80     
===========================================
+ Hits          1800     2021     +221     
- Misses        1375     1674     +299     
  Partials        32       32
Impacted Files Coverage Δ
openfecwebapp/config.py 100% <100%> (ø) :arrow_up:
static/js/modules/columns.js 19.32% <0%> (-1.97%) :arrow_down:
openfecwebapp/constants.py 100% <0%> (ø) :arrow_up:
static/js/modules/charts.js 11.62% <0%> (ø)
static/js/modules/bar-charts.js 10.67% <0%> (ø)
openfecwebapp/routes.py 44.11% <0%> (+0.22%) :arrow_up:
static/js/modules/election-lookup.js 70.96% <0%> (+4.01%) :arrow_up:
openfecwebapp/filters.py 67.12% <0%> (+13.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 240f663...075838f. Read the comment docs.

patphongs commented 7 years ago

@noahmanger Please hold on merging while @LindsayYoung confirms with ATO team

LindsayYoung commented 7 years ago

Closing for now. Ethnio is not approved for the GSA ATO at this time