search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Fix/line numbers #2186

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This makes the itemized individual contributions lines in financial summaries go to the receipts page, filtered down to the correct line number.

It also fixes an issue where the line numbers were only being added for committee_type=O but setting all non candidate committees to O in the financial summary table template in order to get the correct line number value. It's a hacky way to do it, but since we're going to be refactoring how this works soon, it was the quicker, safer solution.

codecov-io commented 7 years ago

Codecov Report

Merging #2186 into release/public-20170713 will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           release/public-20170713    #2186   +/-   ##
========================================================
  Coverage                    56.01%   56.01%           
========================================================
  Files                           51       51           
  Lines                         3226     3226           
  Branches                       388      388           
========================================================
  Hits                          1807     1807           
  Misses                        1387     1387           
  Partials                        32       32
Impacted Files Coverage Δ
openfecwebapp/constants.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23e892a...b540207. Read the comment docs.