search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

[WIP] Feature/remove time period #2202

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This is an initial pass of front-end changes in preparation for removing the two_year_transaction_period filter so that we can test it once the API work is done.

First, it replaces the time-period constricted date filters with regular min and max fields. We may decide we want something more sophisticated, but it's a start.

Second, I basically went through and replaced all instances where a two_year_transaction_period was passed as a URL parameter with min_date and max_date, as defined by the coverage start and end dates for the page you're looking at.

Last, I also did a little cleanup throughout by using the global context object to pass more data to the data tables on the candidate pages, rather than setting everything as data attributes on the tables themselves.

Don't merge until the API work is done.

To do:

Resolves https://github.com/18F/openFEC-web-app/issues/2177

codecov-io commented 7 years ago

Codecov Report

Merging #2202 into develop will decrease coverage by 0.28%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2202      +/-   ##
===========================================
- Coverage    55.82%   55.53%   -0.29%     
===========================================
  Files           51       51              
  Lines         3237     3394     +157     
  Branches       388      422      +34     
===========================================
+ Hits          1807     1885      +78     
- Misses        1398     1477      +79     
  Partials        32       32
Impacted Files Coverage Δ
static/js/modules/other-spending-totals.js 21.95% <ø> (ø) :arrow_up:
openfecwebapp/views.py 39.84% <0%> (+0.43%) :arrow_up:
static/js/modules/column-helpers.js 23.94% <0%> (-0.06%) :arrow_down:
static/js/modules/helpers.js 57% <0%> (+4.18%) :arrow_up:
static/js/modules/columns.js 19.91% <0%> (-1.38%) :arrow_down:
openfecwebapp/constants.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c350a1c...fa3c58a. Read the comment docs.

noahmanger commented 7 years ago

Closing in favor of https://github.com/18F/openFEC-web-app/pull/2213