search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

[MERGE WITH GITFLOW] Hotfix/termination report amendment status #2203

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This resolves an issue where termination reports showed up as an amendment even though they were the original. This is because they have a filing number in their amendment_chain. This change adds special logic for termination reports so that the presence of an self-referential ID in their amendment_chain doesn't make it display as an amendment.

image

image

Resolves https://github.com/18F/FEC/issues/4341 Resolves https://github.com/18F/FEC/issues/4390 Resolves https://github.com/18F/FEC/issues/4388

codecov-io commented 7 years ago

Codecov Report

Merging #2203 into master will decrease coverage by 0.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   55.82%   55.73%   -0.09%     
==========================================
  Files          51       51              
  Lines        3237     3242       +5     
  Branches      388      390       +2     
==========================================
  Hits         1807     1807              
- Misses       1398     1403       +5     
  Partials       32       32
Impacted Files Coverage Δ
static/js/modules/helpers.js 51.02% <0%> (-1.8%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1516038...a1c9c72. Read the comment docs.