search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Simplify front-end build tool workflow #2208

Closed jwchumley closed 7 years ago

jwchumley commented 7 years ago

integrate FEC style without using node modules? (@xtine) Maybe extra tasks too run build icons is broken (only works for Noah and xtine right now)

related to https://github.com/18F/fec-transition/issues/104

Will need clean up after merge.

xtine commented 7 years ago

To clarify this issue, this involves updating the front end build tools from gulp+browserify to webpack on both openfec-web-app and fec-cms. Node modules will always be used, but the other issue about combining webapp and cms it will mean the css/js in fec-style will be integrated to the unified app and fec-style itself wont need to be a node module.

xtine commented 7 years ago

Also, the build icons wont work for me and currently only work for noah. I havent done icon compiling in webpack yet, but that might solve the compiling issue for everyone else.