fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Use text filter for candidate name on IE page #2209

Closed noahmanger closed 6 years ago

noahmanger commented 7 years ago

As uncovered in https://github.com/18F/FEC/issues/4256, some IE transactions are missing the candidate ID coding, so the current candidate ID filter could exclude this data.

I'm not sure how widespread of an issue this is. The best solution would be to guarantee IDs for every transaction. If that's not possible, the easiest solution is to replace the typeahead candidate_id filter with a regular text filter that filters on candidate_name.

Doing so requires a few changes:

Preliminary questions:

noahmanger commented 7 years ago

Ok I think I have my answer for the question of aggregates. It seems they're built with candidate_id which means that in the case of Bob Gray, those 45Committee IEs don't show up: image

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1592 via ZenHub