search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Consider changing "memo code" to "memo item" on details panel #2212

Closed PaulClark2 closed 6 years ago

PaulClark2 commented 7 years ago

So that users can more easily understand memo items reported on various financial forms.

Currently we display memo code true or memo code false. It might be easier to understand and to explain if we use memo item yes and memo item no.

Related to https://github.com/18F/FEC/issues/4407

noahmanger commented 7 years ago

This could also be a good thing to add to the glossary.

PaulClark2 commented 7 years ago

Tagging @jameshupp in. James part of this discussion is in https://github.com/18F/FEC/issues/4407

jameshupp commented 7 years ago

Yes, and yes. My initial reaction in reviewing https://github.com/18F/FEC/issues/4407 is that Memo item: yes/no makes a ton of sense.

Honestly, the clearest pattern to me, I would think, is:

  1. Switch to Memo item: yes/no, as described above.
  2. Reverse the position of Memo item and Reported on to separate Memo item from Memo, since I don't think whether it's a memo item has anything to do with whether there is a memo on it. And having them next to each other looks awfully confusing.
  3. Add glossary definitions for Memo and Memo item. I just can't imagine people aren't going to be confused by these in general.
PaulClark2 commented 7 years ago

Does it help to call memo memo text and memo code memo item? Memo (memo text) is an additional description of the transaction provided by the filing committee.

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1574 via ZenHub