fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

6 year date selection #2213

Closed noahmanger closed 6 years ago

noahmanger commented 7 years ago

This makes several changes to the front-end to support 6 years of schedule A and B data at a time.

This also includes a fix so that other spending aggregates on candidate page link to the full 4 or 6 year time period for IEs, ECs, and CCs (resolves https://github.com/18F/openFEC-web-app/issues/2133).

codecov-io commented 7 years ago

Codecov Report

Merging #2213 into develop will increase coverage by 0.02%. The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2213      +/-   ##
===========================================
+ Coverage    54.84%   54.86%   +0.02%     
===========================================
  Files           55       55              
  Lines         3364     3359       -5     
  Branches       409      410       +1     
===========================================
- Hits          1845     1843       -2     
+ Misses        1487     1484       -3     
  Partials        32       32
Impacted Files Coverage Δ
static/js/modules/other-spending-totals.js 21.95% <ø> (ø) :arrow_up:
static/js/modules/column-helpers.js 23.61% <0%> (-0.39%) :arrow_down:
openfecwebapp/views.py 39.84% <0%> (+0.43%) :arrow_up:
openfecwebapp/app.py 71.42% <33.33%> (-0.8%) :arrow_down:
static/js/modules/tables.js 51.57% <40%> (ø) :arrow_up:
static/js/modules/helpers.js 49.67% <50%> (-0.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5539793...07e76f7. Read the comment docs.

jenniferthibault commented 6 years ago

Closing this in favor of work in https://github.com/18F/fec-cms/issues/1371 which will use the work started here, but will need to be refactored to work in the fec-cms repo