search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Adding SeekPaginator to itemized tables on profile pages #2224

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This fixes an issue where the itemized tables on committee pages (and the disbursement table on candidate pages) wouldn't page through.

This is because itemized receipts and disbursement tables (which use schedule_a and schedule_b endpoints) use the SeekPaginator option, which paginates through using last_index rather than page.

Resolves https://github.com/18F/FEC/issues/4416

codecov-io commented 7 years ago

Codecov Report

Merging #2224 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2224   +/-   ##
========================================
  Coverage    55.73%   55.73%           
========================================
  Files           51       51           
  Lines         3242     3242           
  Branches       390      390           
========================================
  Hits          1807     1807           
  Misses        1403     1403           
  Partials        32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b29a24...b5f8824. Read the comment docs.