search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/elections improvements #2231

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This is some old work I started to re-do the elections pages in the new templates. It also contains the new comparison button for candidate pages, though needs the design from https://github.com/18F/openFEC-web-app/issues/2198 applied.

Update: this is ready now. I finished up the styling by pairing with @jenniferthibault , added the compare button to the candidate page, and also fixed a bug where the maps on the comparison page weren't showing (resolves https://github.com/18F/openFEC-web-app/issues/2204).

image

image

image

image

codecov-io commented 7 years ago

Codecov Report

Merging #2231 into develop will decrease coverage by <.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2231      +/-   ##
===========================================
- Coverage    55.53%   55.53%   -0.01%     
===========================================
  Files           54       54              
  Lines         3297     3299       +2     
  Branches       398      398              
===========================================
+ Hits          1831     1832       +1     
- Misses        1434     1435       +1     
  Partials        32       32
Impacted Files Coverage Δ
static/js/modules/maps.js 25.83% <100%> (ø) :arrow_up:
openfecwebapp/filters.py 53.22% <50%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ff0738...fd9aa2e. Read the comment docs.