search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

[WIP] Make api_caller logs more verbose #2233

Closed LindsayYoung closed 6 years ago

LindsayYoung commented 7 years ago

This error message includes the status code of the API call that fails. Have not tested locally yet

codecov-io commented 7 years ago

Codecov Report

Merging #2233 into develop will decrease coverage by 0.01%. The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2233      +/-   ##
==========================================
- Coverage    55.71%   55.7%   -0.02%     
==========================================
  Files           51      51              
  Lines         3245    3251       +6     
  Branches       392     392              
==========================================
+ Hits          1808    1811       +3     
- Misses        1405    1408       +3     
  Partials        32      32
Impacted Files Coverage Δ
openfecwebapp/api_caller.py 55.68% <42.85%> (-0.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82bfa44...b21ef5e. Read the comment docs.

jenniferthibault commented 6 years ago

@LindsayYoung @ccostino how should we handle this PR now that we've merged repos?

ccostino commented 6 years ago

Oooh this is a good one to pick back up since it is not incorporated into the merge, thanks @jenniferthibault!

The changes are lightweight enough that we can just open a new PR on the fec-cms side and continue in there. I'll get that done now so we can close this. :-)

ccostino commented 6 years ago

https://github.com/18F/fec-cms/pull/1537 now in place, so this is good to close!