search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

[MERGE WITH GIT FLOW] Adding SeekPaginator to itemized tables on profile pages #2241

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This fixes some bugs where transaction tables on candidate and commitee pages wouldn't paginate correctly. This is because we have two types of paginators: the default is OffsetPaginator which uses page=X to page through. Schedule A and B tables use SeekPaginator which uses the last_index value to page through.

To test, verify that the itemized tables on this page and this page can page through.

codecov-io commented 7 years ago

Codecov Report

Merging #2241 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2241   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files          51       51           
  Lines        3242     3242           
  Branches      390      390           
=======================================
  Hits         1807     1807           
  Misses       1403     1403           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3d2054...28561d0. Read the comment docs.