search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Use .csv extension for download filename #2242

Closed vrajmohan closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #2242 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2242   +/-   ##
========================================
  Coverage    55.71%   55.71%           
========================================
  Files           51       51           
  Lines         3245     3245           
  Branches       392      392           
========================================
  Hits          1808     1808           
  Misses        1405     1405           
  Partials        32       32
Impacted Files Coverage Δ
static/js/modules/download.js 90.07% <100%> (ø) :arrow_up:
static/js/modules/tables.js 51.57% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e1344e...fe1e7cb. Read the comment docs.

noahmanger commented 7 years ago

I'm assuming we want to wait to merge this until the API change is done? https://github.com/18F/openFEC/pull/2584

vrajmohan commented 7 years ago

True. Even more, we need to discuss how to deploy this so that no downloads are clobbered.