search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Adding cms_url to manifests #2253

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

The issue with the "Home" link in the breadcrumbs not linking to the home page (https://github.com/18F/openFEC-web-app/issues/2244) appears to be due to a missing FEC_CMS_URL env variable. This adds it to the manifests for all three environments.

Resolves https://github.com/18F/openFEC-web-app/issues/2244

codecov-io commented 7 years ago

Codecov Report

Merging #2253 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2253   +/-   ##
========================================
  Coverage    55.71%   55.71%           
========================================
  Files           51       51           
  Lines         3245     3245           
  Branches       392      392           
========================================
  Hits          1808     1808           
  Misses        1405     1405           
  Partials        32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0677a0b...6f71787. Read the comment docs.

noahmanger commented 7 years ago

AFAIK, yes. These are just used to build absolute links to CMS pages from the web app.