fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Add links to election pages from data landing #2260

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

I forgot to include actual links on this part of the data landing, so this adds them:

image

It also adds the correct link to the election page from candidate pages: image

And updates the state + district selects on election pages to go to the page similar to how it works on the data landing page: image

And last, I fixed an issue where not all district results were showing up when doing a state search by adding per_page=100 to API calls for the election lookup. Resolves https://github.com/18F/openFEC-web-app/issues/2256

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/public-20170811@9c27862). Click here to learn what that means. The diff coverage is 40%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##             release/public-20170811    #2260   +/-   ##
==========================================================
  Coverage                           ?   55.45%           
==========================================================
  Files                              ?       54           
  Lines                              ?     3307           
  Branches                           ?      398           
==========================================================
  Hits                               ?     1834           
  Misses                             ?     1441           
  Partials                           ?       32
Impacted Files Coverage Δ
openfecwebapp/routes.py 44.08% <ø> (ø)
static/js/modules/election-form.js 83.67% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c27862...63cfcef. Read the comment docs.

noahmanger commented 7 years ago

Added a few more things to this PR and updated the message accordingly.