search

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Feature/boolean search #2263

Closed noahmanger closed 7 years ago

noahmanger commented 7 years ago

This is a companion PR to https://github.com/18F/fec-cms/pull/1205 , adding the boolean search field modal to the advanced legal resources search pages. It adds it to AOs, MURs, statutes and regs, and basically works the same in all cases.

demo

Note, rather than putting the keyword-modal.js code in fec-style, I just made two copies, one here and one in the CMS, since we're going to merge the apps soon. There's just a slight logic difference between the two, which I noted in the comments. The key difference is that for these searches, rather than submitting the form, it just updates the ?search= param in the URL. This way it works with the React AO filters as well as the regular HTML form fields for the other searches.

The one trade-off at the moment is that on the AO page, it forces a full refresh of the page. This can maybe be resolved in a later step, but didn't feel worth holding up.

I also fixed the JSHint errors by telling it to ignore files in the /legal/ directory, which use newer JS that the current JSHint settings aren't configured for. And I moved the build-legal build script to the gulpfile for consistency and to get sourcemaps working.

Thanks to @anthonygarvan for the guidance.

codecov-io commented 7 years ago

Codecov Report

Merging #2263 into develop will decrease coverage by 0.61%. The diff coverage is 19.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2263      +/-   ##
===========================================
- Coverage    55.53%   54.91%   -0.62%     
===========================================
  Files           54       55       +1     
  Lines         3299     3356      +57     
  Branches       398      409      +11     
===========================================
+ Hits          1832     1843      +11     
- Misses        1435     1481      +46     
  Partials        32       32
Impacted Files Coverage Δ
static/js/legal/Filters.js 80% <ø> (ø) :arrow_up:
static/js/modules/keyword-modal.js 18.18% <18.18%> (ø)
static/js/legal/filters/TextFilter.js 63.63% <50%> (-3.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c27862...967d2e3. Read the comment docs.

xtine commented 7 years ago

Front-end looks good. Also modal works well in mobile as well.