limited version of the committee financial summary pages

fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code

Other

43 stars 31 forks source link

limited version of the committee financial summary pages #2274

Closed PaulClark2 closed 6 years ago

PaulClark2 commented 7 years ago

So that users can search committee financial information we could create a limited version of the committee financial summary pages using the existing /totals/[committee-type]/ endpoint. We could make separate ones for: presidential, house-senate, pac, and party, and include top-level financial totals. The filters are much more limited on these right now, but it's a start.

[x] add COH to candidate office pages
[x] add ending coverage date to candidate office pages
[x] make PACs data table page
[x] make party committees data table pages
[ ] optional House, Senate and Presidential committee data table pages

noahmanger commented 7 years ago

Ok I got this as far as it can go until the API is updated. Also, I made these changes in a branch in the CMS off of the combined app, so it will have to wait until that's merged in as well, which should line up.

Cash on hand on candidate pages:

With coverage dates in the details panel:

PAC page (waiting on committee name being added to API):

Party page (waiting on committee name and party being added to API):

jenniferthibault commented 6 years ago

This issue is a bit stale so wanted to check in. I saw from the release notes that we added additional fields and filters to the API

Does this enable us to push this issue forward to finish the work, merge it in, and close it? Or is the work already in a merged PR?

AmyKort commented 6 years ago

Are we ready to close this? Is there a next step we should address?

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1599 via ZenHub