fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Committee filing pages displaying more than one "Current" Form 1 (Statement of Organization) #2285

Closed lbeaufort closed 6 years ago

lbeaufort commented 7 years ago

So that committees and the public can see the most recent version of the Form 1 (Statement of Organization), we need to update the logic to handle when a committee files multiple Form 1's as new and only show the newest as "Current Version" and the others as "Past Version."

@patphongs discovered this issue.

Example: (https://www.fec.gov/data/committee/C00639013/?tab=filings)

8-31-2017 3-35-01 pm

Background: Using FECFile and other 3rd party vendors, committees can amend their Statement of Organization (Form 1) by filing it as new. Then, an overnight process updates it to show as amended. As a result, there is no amendment number associated with the file that was submitted as new and now displays as amended.

Potential fix: Add to /filings/ "amendment chain" logic to handle multiple F1Ns for the same committee. If the amendment chain logic fails (>1 current version for the same filing type - for statements of org. ) then use the most recently filed one as the current version and mark the others as past version.

AmyKort commented 6 years ago

Issue moved to 18F/fec-cms #1554 via ZenHub