Closed jenniferthibault closed 6 years ago
@dorothyyeager and @gsmaragdis -- just flagging this one for you.
@jenniferthibault: I just realized that this page is one of the tour pages. The points currently are at the Hero heading, Dates and deadlines section, and sidebar. How are these going to be changed?
@johnnyporkchops: did you want to get started on this? I've written some notes, and then we can also pair with @dorothyyeager and @lbeaufort once you've gotten started.
/fec-cms/fec/home/templates/candidate-and-committee-services/services_landing_page.html
container
and main
classes{% include 'partials/disclaimer.html' %}
after closing container divHero
Guides
Popular Topics
option u-margin—top
heading--section heading--with-action
classes, look at home page for reference how this is usedbutton--alt
@xtine Based on https://github.com/18F/fec-cms/issues/1251 @AmyKort did a quick slack convo and it looked like the preference was to turn the site tour off—so I think don't need to account for the tour adjustment for this issue.
Thanks!
"You might also like" text and links for when we rebuild the page in wagtail on prod:
Look up information reported and filed with the FEC Search for your committee's information and filings Statements of candidacy filed by office Statements of organization filed by committees
Learn about enforcement of federal campaign finance law Enforcement overview Search matters under review (MURs) Search advisory opinions (AOs)
Get help from an FEC analyst Find and contact your analyst
cc @johnnyporkchops
I included .jpg and .png at 1x & 2x — please rename the files as needed, I'm not sure what the naming conventions you @xtine and @patphongs are following
Will get to this in this sprint and try to get it merged into dev in time for the upcoming November conference testing.
Reviewed this today and things are looking good. We discussed the new naming convention for images and updating the infoblock image implementation to be more consistent throughout. In design pairing, we'll sync up about any loose ends before merging this in.
This has been completed and merged into dev from this PR https://github.com/18F/fec-cms/pull/1441
Discussion and history in https://github.com/18F/openFEC-web-app/issues/2185
@xtine @lbeaufort @dorothyyeager
Designs
Notes
Links
Tasks to completion:
Dependencies