fecgov / openFEC-web-app

DEPRECATED See https://github.com/18F/fec-cms for fec.gov's code
Other
43 stars 31 forks source link

Legal resources "Edit filters" styles are incorrect #2290

Closed jenniferthibault closed 6 years ago

jenniferthibault commented 7 years ago

Not sure when this bug was introduced, but there's a small styling bug happening in the legal resources filter panel that should get squashed before it spreads:

In the Statutes, MUR, and AO advanced search page, the "Edit filters" text is incorrectly styled using the sans serif font. It should have the serif styling, like the rest of the data tables. Below is the correct styling on the left Individual contributions table, and the incorrect AO/MUR styling on the right.

screen shot 2017-09-01 at 10 17 21 am

I tried the inspector, but it's not immediately clear ot me what's causing it to inherit these styles.

cc @xtine (not urgent, just flagging for you)

cptechiegal commented 7 years ago

please include/pair with cristl @cptechiegal

lbeaufort commented 6 years ago

@jenniferthibault when I went to look into this, it looks like the fonts all match. Do you mind taking a look? I'm on my Mac, in Chrome. Version 61.0.3163.100 (Official Build) (64-bit)

Statutes, image.png

MUR, image.png

and AO advanced search page image.png

Individual Contributors image.png

jenniferthibault commented 6 years ago

I'm also not seeing the style discrepancies anymore. My favorite issues are the ones that resolve themselves! Feel free to close.

lbeaufort commented 6 years ago

Closed - resolved itself. Verified w/@jenniferthibault, thanks!