Creating MUR filter for date opened and date closed

[AmyKort]

Users searching our MUR holdings still have difficulty searching MURs opened or closed during specific time periods. We need to add a filter option to allow users to set date opened and date closed filters for MURs.

Jen may already have much of this work completed.

• [ ] create the filter
• [ ] write test for filter

[jenniferthibault]

:female_detective: GitHub archeology is one of my favorite things because I get to rediscover the awesome work and thinking our teammates have already done!

Nicky documented the most up-to-date filter designs and concepts for MURs, ADRs, and Admin fines in https://github.com/18F/openFEC-web-app/issues/1797#issuecomment-275701188 This will be a good issue to keep handy.

Pulling out the MUR filters specifically, and zooming in on the time period concepts, the question in orange was a content design question about the field label:

@xtine can you help assess if the components on the API/back end are in place for the case data & violation date concepts to work?

[jenniferthibault]

Rebumping to @xtine for taking a look at the front end needs 👋

[lbeaufort]

@jenniferthibault if it's not too much work, there were two recent requests to add MUR number to the search, like the AO search:

https://github.com/18F/FEC/issues/4583 https://github.com/18F/FEC/issues/4460

[AmyKort]

I think we've had that functionality for a while, but it was difficult to find https://www.fec.gov/data/legal/search/enforcement/?search=&search_type=murs

Am I misunderstanding @jenniferthibault ? (because that has been the theme of my day) Are you suggesting we integrate the filters differently?

[lbeaufort]

@AmyKort @jenniferthibault Sorry I was unclear - I think the request was to make it easier to find, or on the search landing page, similar to the AO search (below). I met a new EA today who mentioned she had recently submitted feedback, and when I was looking through the feedback I discovered two requests for MUR number search that I thought could have come from our internal users.

[AmyKort]

Super! Thanks @lbeaufort !

[jenniferthibault]

@lbeaufort what you're looking for has already been added via https://github.com/18F/fec-cms/pull/1276 and you can take a look on staging. It will go out with the release. 🎉

This issue is about adding the date opened/closed filters to the actual full filter list available in the advanced MUR search sidebar, at this link: https://www.fec.gov/data/legal/search/enforcement/?search_type=murs

And will be seen here:

This is a piece of an issue where we had all the research and designs for the full filter list finished a long time ago, (check them out in https://github.com/18F/openFEC-web-app/issues/1797#issuecomment-275701188!) but haven't had the engineering support available to implement them, so we're adding them piece by piece.

Does that clear things up am I misunderstanding and adding more confusion?

[jenniferthibault]

PS: @lbeaufort this is also a good reminder using my own bad example: no matter how "urgent" the fix or how inexperienced the dev (me, in this case!) including a proper pull request description and linking the PR to existing issues filed is a core part of working in the open and documenting what/how/why we're making these changes. Thanks you for training the trainers 😄

[lbeaufort]

@jenniferthibault That is awesome, thanks!

[AmyKort]

cc @johnnyporkchops

[jenniferthibault]

Thanks to @lbeaufort 's awesome demo today, it looks like her pull request https://github.com/18F/openFEC/pull/2712 adds the work that makes this information available to use on the front end via a change to the endpoint. (I think, but may be misrepresenting.)

So if it's available, this is a front end implementation issue to add the feature to the MUR search filters!

[jenniferthibault]

Issue moved to 18F/fec-cms #1533 via ZenHub