Time period incorrect for House special election candidates

[PaulClark2]

What we’re after: We should display the correct two-year period (Time period:) for all candidates.

Current state: The two-year period (Time period:) for House special election candidates is incorrect. The Time period: of odd-year special elections should be the election year plus one not election year minus one.

Examples:

• https://www.fec.gov/data/candidate/H8GA06195/
• https://www.fec.gov/data/candidate/H8GA06286/

Screenshot:

Completion criteria:

• [x] determine cause of the incorrect Time period:: front-end or API issue This was a front-end issue
• [x] display the correct Time period: This was resolved by PR1708/Issue#1644 Election Year correction

Related issues or PRs: https://github.com/18F/fec-cms/issues/1644 https://github.com/18F/fec-cms/issues/1642 https://github.com/18F/fec-cms/pull/1677

[LindsayYoung]

This is a front end task. We calculate the time period depending on the 2-4-6 aspect of the data. I think we will want to start off the the calculation by getting the end year of the cycle with something like n = n + n % 2

[cptechiegal]

House Candidate: Ossoff https://www.fec.gov/data/candidate/H8GA06195/

• Webpage Time Period This candidates's Time Period: 2016-2017 is including the Coverage Dates Time Period | Filings Years (Cycles) | Coverage Dates: 2016-2017 | 12/21/2016 to 09/30/2017

However, request seems to prefer the Time Period to be 2017-2018. @PaulClark2 should Time Period display Years based on coverage dates or Election year?

API Candidate Filings endpoint - returns Filings Coverage Start/End dates that are null see API Request: https://api.open.fec.gov/v1/candidate/H8GA06195/filings/?page=1&per_page=20&api_key=DEMO_KEY&sort=-receipt_date

• Related Issue with Election Year set to 2017 but should display even Election year (this was resolved with issue#https://github.com/18F/fec-cms/issues/1644 / PR1708) Webpage / GUI Display Election | Time Period | Filings Years | Years (Cycles) | Coverage Dates: 2017 | 2016-2017 | 12/21/2016 to 09/30/2017

API results: (FEC) Election Years | Candidate Election Years | Cycles election_years | candidate_election_year. | cycles | two_year_period 2017 | 2017 | 2018 | 2018 2017 | 2017 | 2018 | 2018

API testing below indicates that API returns 2017 for elections years and 2018 for cycles. API Testing: https://api.open.fec.gov/developers/#!/candidate/get_candidate_candidate_id_history_cycle

request: https://api.open.fec.gov/v1/candidate/H8GA06195/history/?per_page=20&api_key=DEMO_KEY&sort=-two_year_period&page=1&election_full=false

• Related issue, the Raising page has the election year: 2018 but should probably display as 2 year periods instead (note: this data is from cycles data - see issue# https://github.com/18F/fec-cms/issues/1647)

[cptechiegal]

Same issues for House Candidate: Handel https://www.fec.gov/data/candidate/H8GA06286/

• Webpage Election years should display as even years (this was resolved with issue#1644 / PR1708)

• Time Period for Election This candidates's Time Period: 2016-2017 is including the Coverage Dates Webpage/ GUI Display Election | Time Period | Filings |   Years | Years (Cycles) | Coverage Dates: |   2017 | 2016-2017 | 01/01/2017 to 09/30/2017 |   However, request seems to prefer the Time Period to be 2017-2018.

• API Filings Coverage Start/End dates are null API request: https://api.open.fec.gov/v1/candidate/H8GA06286/filings/?page=1&per_page=20&api_key=DEMO_KEY&sort=-receipt_date

[cptechiegal]

Technical research: The Time Period is handled in the subcycle-select component (GUI template)

Time period: 2016–2017

The Time Period sub cycle component is displayed using the Handlebars templates: electionCycle.hbs and electionCycles.hb The initCycles code in cycle-select.js is where the min and max cycle is determined. The code uses the selected cycle (assuming even year) to setup the min and max cycles For single cycle (house) setting max=selected and min= selected -1 This seems to be coded correctly when input cycle is correct end year.

This is working correctly now, once PR1708 (issue#1644) is released, correcting the issue with the odd value Election year changed to even Election year which ensures the input is the correct end year.

[patphongs]

should be fixed in the next release with this merged PR https://github.com/18F/fec-cms/pull/1708

Closing this issue