fecgov / openFEC

The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.
https://api.open.fec.gov/developers
Other
479 stars 106 forks source link

Remove incumbent data from /elections/search/ endpoint #3247

Closed lbeaufort closed 6 years ago

lbeaufort commented 6 years ago

Remove incumbent data from /elections/search/ endpoint - there are data problems and this is unused on the front end. Election profile pages pull data from /elections/

Method

To check the incumbent flags in the /elections/ endpoint, @llienfec pulled data from the /elections/search/ API endpoint (had all the needed data). Compared incumbents listed by district to external data sources, looking for discrepancies and researching the differences. It was a lot of data, so apologies for any oversights/spelling issues!

Data

Lauren's full research notes are here: :lock: https://docs.google.com/spreadsheets/d/1N-v4NSycB6JE54BIRmrvWPI74F-GA8C82Nb5lgRuEcM/edit?usp=sharing :lock: @rhoughfec is good at interpreting my massive spreadsheets in case anything needs deciphering while I'm out of the office next week.

Findings summary

House changes (not including PA)

State District API incumbent Incumbent should be Reason
AZ 08 Null Debbie Lesko Won special election
GA 06 Thomas Price Karen Handel TP appointed to HHS; KH won special
KS 04 Null Ron Estes Pompeo appointed to State; RE won special
MT 08 Null Greg Gianforte Zinke appointed to Interior; GG won special
NC 02 Null George Holding
NC 13 George Holding Ted Bud
NY 25 Louise Slaughter Null Incumbent deceased; seat vacant
OH 12 Patrick Tiberi Null Resigned Oct 2017; will have an incumbent to flag after 8/7/18 special
OK 01 James Bridenstine Null Appointed to NASA; seat vacant
UT 03 Jason Chaffetz John Curtis Resigned April 2017; JC won special

House updates for PA redistricting

Note districts 03 and 17 have 2 incumbents running.

New district Incumbent should be Old district
01 Brian Fitzpatrick 8
02 Brendan Boyle 13
03 Bob Brady 1
03 Dwight Evans 2
04 Open seat
05 Vacant
06 Ryan Costello 6
07 Vacant
08 Matt Cartwright 17
09 Lou Barletta 8
10 Scott Perry 4
11 Lloyd Smucker 16
12 Tom Marino 10
13 Bill Schuster 9
14 Open
15 Glenn Thompson 5
16 Mike Kelly 3
17 Keith Rothfus 12
17 Conor Lamb 18
18 Mike Doyle 14

Senate updates

Senate class State API incumbent Incumbent should be Reason
Class 1 - 2018 MN Tina Flint Smith Amy Klobuchar AK holds the Class 1 seat. TFS holds the Class 2 seat
Class 2 - 2020 AL Jeff Sessions Doug Jones JS appointed to DOJ; DJ won special
Class 2 - 2020 AL Al Franken Tina Flint Smith Won special in 2018 for Class 2 seat
Class 2 - 2020 MS Thad Cochran Null Resigned and Cindy Hyde-Smith was appointed by governor
Class 3 - 2022 IL Null Tammy Duckworth
Class 3 - 2022 IN Null Todd Young
Class 3 - 2022 WI Null Ron Johnson

@llienfec commented on Thu May 31 2018

@PaulClark2 This research is finished, so I'm closing the issue. We may need an implementation issue to fix some of the incumbents in the charts above. Thanks!

jwchumley commented 6 years ago

@lbeaufort I usually use this: https://json-csv.com/ to convert to cvs. I don't know what the data limit is

lbeaufort commented 6 years ago

Thanks, @jwchumley. I moved over @llienfec's research ticket for implementation. I have some questions though - the election profile page pulls from /elections/ not /elections/search/, which I think have different data sources. I'd need to investigate further to be sure.

llienfec commented 6 years ago

Thanks for looking into this further. I didn't realize they were so different. There was something about /elections/ that didn't have quite enough info - sorry for the mis-match. Happy to quality check a different endpoint.

The converter I used was https://www.csvjson.com/json2csv