search

fecgov / openFEC

The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.
https://api.open.fec.gov/developers
Other
479 stars 106 forks source link

Swagger Documentation is incorrect #3439

Open cervella opened 5 years ago

cervella commented 5 years ago

Small issue, but Pre-Primary Reports are coded in the swagger page here (https://api.open.fec.gov/swagger/) as 10P, when they should be 12P screenshot 2018-10-15 13 35 45

lbeaufort commented 5 years ago

Thanks for reporting, @cervella! Would you be interested in putting in a pull request?

lbeaufort commented 5 years ago

@cervella I apologize, it looks like there are filings with report type 10P: https://api.open.fec.gov/v1/filings/?sort_null_only=false&report_type=10P&sort=-receipt_date&page=1&api_key=DEMO_KEY&per_page=100&sort_hide_null=false.

It looks like historical data - I will investigate these report types and make sure the list is correct.

cervella commented 5 years ago

Thanks for getting back to me @lbeaufort!

I just ran reports using this API (which is an amazing addition to my life) and noticed none of the current reports were being pulled with 10P, but the ones I expected were in 12p, as referenced here:https://www.fec.gov/campaign-finance-data/report-type-code-descriptions/

jwchumley commented 5 years ago

Yes. I was digging into this. I know the "10" series were an actual thing at some point but I don't remember the details. I'll find out and maybe we can update the swagger ui descriptions with the context.

Jeff Chumley

Electronic Filing, Web and Disclosure Branch Manager

Federal Election Commission

From: Laura Beaufort notifications@github.com Sent: Monday, October 15, 2018 1:59 PM To: fecgov/openFEC Cc: Subscribed Subject: Re: [fecgov/openFEC] Swagger Documentation is incorrect (#3439)

@cervellahttps://github.com/cervella I apologize, it looks like there are filings with report type 10P: https://api.open.fec.gov/v1/filings/?sort_null_only=false&report_type=10P&sort=-receipt_date&page=1&api_key=DEMO_KEY&per_page=100&sort_hide_null=false.

It looks like historical data - I will investigate these report types and make sure the list is correct.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/fecgov/openFEC/issues/3439#issuecomment-429953155, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMCA7zdKbG_dIoR3AcmcYfBPHtF5WHrQks5ulM0BgaJpZM4Xc0vP.