Research rewrite to remove 'import app'

fecgov / openFEC

The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.

https://api.open.fec.gov/developers

Other

483 stars 106 forks source link

Research rewrite to remove 'import app' #4448

Open lbeaufort opened 4 years ago

lbeaufort commented 4 years ago

What we're after: We should rewrite to remove 'import app'. This is an anti-pattern. https://flask.palletsprojects.com/en/2.3.x/patterns/appfactories/

This is blocking flask sqlalchemy/sqlalchemy upgrades.

Action items:

[ ] Consider talking to DBA team about sample data
[ ] Build out a plan/model for this change
[ ] Create follow-up implementation ticket(s)

Completion criteria:

[ ] Research has been documented here in the ticket

Future work:

Look at the CMS

rochacbruno commented 4 years ago

Let me know if you need some eyes on it, I would be happy to help on it, I was reading the source code and maybe dynaconf can help making the code easier to maintain by putting all the registration and configuration in config files. (bias allert! I am the Dynaconf maintainer)

My slides on that topic are here: https://skip.gg/flask-factories-flaskcon and recordings