fecgov / openFEC

The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.
https://api.open.fec.gov/developers
Other
483 stars 106 forks source link

Change "notification" to "report" for 24/48 hour report #5222

Closed hcaofec closed 2 years ago

hcaofec commented 2 years ago

What we’re after

On this page, we would like to change "notification" to "report" for all 24/48 hour reports

https://www.fec.gov/data/committee/C00530766/?tab=filings#notices

api:
https://api.open.fec.gov/v1/filings/?api_key=DEMO_KEY&sort_hide_null=false&sort_nulls[…]_type=-7&request_type=-8&request_type=-9&election_full=false.

Action item(s)

Completion criteria

PaulClark2 commented 2 years ago

Thank you @hcaofec. Can we make the case statement something like this?

when form_tp in ('F24', 'F5') and rpt_tp = '24' then '24-HOUR REPORT OF INDEPENDENT EXPENDITURES' when form_tp in ('F24', 'F5') and rpt_tp = '48' then '48-HOUR REPORT OF INDEPENDENT EXPENDITURES' when form_tp = 'F6' then '48-HOUR NOTICE OF CONTRIBUTIONS OR LOANS RECEIVED'

PaulClark2 commented 2 years ago

I guess the labels should be in all caps to match what's on the website. I've updated my comment above.