search

fecgov / openFEC

The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.
https://api.open.fec.gov/developers
Other
483 stars 106 forks source link

Research adding more test coverage to the legal endpoints #6017

Closed tmpayton closed 4 weeks ago

tmpayton commented 1 month ago

What we’re after

We need to increase our test coverage of the legal search endpoints. This might require integration testing with elasticsearch in circleci. We need to do research on the feasibility of this.

Related ticket(s)

(Include the tickets that either came before, after, or are happening in tandem with this new ticket)

Action item(s)

(These are the smaller tasks that should happen in order to complete this work)

Completion criteria

(What does the end state look like - as long as this task(s) is done, this work is complete)

References/resources/technical considerations

(Is there sample code or a screenshot you can include to highlight a particular issue? Here is where you reinforce why this work is important)

tmpayton commented 4 weeks ago

I've determined that it is feasible to do integration testing with elasticsearch. It's relatively straight forward to add a docker container for elasticsearch to our circleci pipeline and so far has only added less than a minute to the build process.