peer-to-peer code review

HectorTorresE commented 2 years ago

Best Sides

Descriptive commits
desktop version looks perfect

Suggestions

some margin problem when expanding the website

jpol01 commented 2 years ago

Great job, I can see that you have been working a lot on this project. Hector already mentioned some of the issues that need your attention, great job so far.

Kakalanp commented 2 years ago

Your project seems wonderful so far! But there are a few things you could improve. 🔍

The cards seem to break on higher resolutions, Kindly make these have a max-width (It could be 420px or so) so they don't stretch too much 👌

https://github.com/fed1k/Personal-Portfolio.github.io/blob/b448a2404001b9fa9162e15b5cb071b76c6faf28/index.html#L53-L62

If you do constrain your card with a max-width, be careful of this part: https://github.com/fed1k/Personal-Portfolio.github.io/blob/b448a2404001b9fa9162e15b5cb071b76c6faf28/app.css#L147 You'll need to give it a width relative to its container (It could be width 90% or so) so it stays inside. 👍

fed1k / Personal-Portfolio.github.io

peer-to-peer code review #3