es_install_oss variable

fedelemantuano / ansible-kibana

Ansible role for Kibana

https://galaxy.ansible.com/fedelemantuano/kibana

Apache License 2.0

17 stars 20 forks source link

es_install_oss variable #3

Closed sdarwin closed 5 years ago

sdarwin commented 5 years ago

Hi Fedele, Thanks for creating the ansible role!
So, the standard version of Kibana has a number of interesting features which aren't available in the OSS version. "this role doesn't manage xpack, it can install only oss version".
Only oss version... It seems like it would be preferable to install regular Kibana, unless oss is requested, and be able to support both.

Toggle based on this variable: es_install_oss: false
Remove all mentions of xpack since that's not being managed.
refer to the changes in this pull request, let me know what you think.

sdarwin commented 5 years ago

considering variable names...
since the new variable es_install_oss really only applies to kibana currently, and not the entire stack, it could be renamed to kibana_install_oss instead of es_install_oss.

fedelemantuano commented 5 years ago

Hi @sdarwin, I created this role to work with official ansible elasticsearch role, so the name of variables are equal to this role. I'd like to develop complete role, with also x-pack, but I didn't have a lot of time, so I made this role only for open version and then I wrote to elasticsearch team for help. But we can work together to make it.

fedelemantuano commented 5 years ago

Hi @sdarwin,

thanks a lot for your PR. I aligned Red Hat part and added the possibility to pass from oss to xpack and vice versa. The role elasticsearch now doesn't have this possibility, but I opened an issue (https://github.com/elastic/ansible-elasticsearch/issues/520).