codecov[bot]
commented
3 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.01%. Comparing base (
c79a669) to head (fabb788). Report is 294 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #359 +/- ## ========================================== + Coverage 75.33% 76.01% +0.68% ========================================== Files 27 27 Lines 3608 3611 +3 ========================================== + Hits 2718 2745 +27 + Misses 890 866 -24 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR addressed Issue #271 separating the logic for when file logging and console logging happen so you can, for example, have file logging without console logging.
I have also written tests to check that the logging happens. These tests are a little different from previous tests I have written in that they capture stderr to determine if the appropriate console logging happened (they also check that the files that are written contain some of the appropriate content).