feder-observatory / stellarphot

Stellar aperture photometry
https://stellarphot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Finish photometry notebooks #381

Closed mwcraig closed 1 month ago

mwcraig commented 2 months ago

This pull requests finishes off the notebooks needed to perform photometry in 2.0.

Still to do:

NOTE:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 67.88991% with 35 lines in your changes missing coverage. Please review.

Project coverage is 52.12%. Comparing base (f31ec85) to head (65f4e5b). Report is 3 commits behind head on main.

Files Patch % Lines
...llarphot/gui_tools/tests/test_profile_and_comps.py 0.00% 29 Missing :warning:
...rphot/gui_tools/tests/test_comparison_functions.py 0.00% 5 Missing :warning:
stellarphot/gui_tools/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #381 +/- ## =========================================== - Coverage 78.49% 52.12% -26.38% =========================================== Files 27 56 +29 Lines 3758 5815 +2057 =========================================== + Hits 2950 3031 +81 - Misses 808 2784 +1976 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwcraig commented 1 month ago

@JuanCab -- this is ready for a look. Sorry it got a little long. Once this is merged it will be possible to perform photometry via notebooks.

I'll work on a separate PR to add some more documentation and another to make the command line approach is fairly straightforward.

I'm not sure why coverage thinks we need to test our test files....